Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 1814853003: Track whether an element was inserted via document.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on #384935 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
index f8861bd75c2ef7f316774ec627b4fe9c149b7b08..5ae46e7e3d73ec283f1d71749d4edf6ffcdad621 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
@@ -57,21 +57,22 @@
namespace blink {
-ScriptLoader::ScriptLoader(Element* element, bool parserInserted, bool alreadyStarted)
+ScriptLoader::ScriptLoader(Element* element, int constructionContextFlags)
: m_element(element)
, m_startLineNumber(WTF::OrdinalNumber::beforeFirst())
- , m_parserInserted(parserInserted)
+ , m_parserInserted(constructionContextFlags & ParserInserted)
, m_isExternalScript(false)
- , m_alreadyStarted(alreadyStarted)
+ , m_alreadyStarted(constructionContextFlags & AlreadyStarted)
, m_haveFiredLoad(false)
, m_willBeParserExecuted(false)
, m_readyToBeParserExecuted(false)
, m_willExecuteInOrder(false)
, m_willExecuteWhenDocumentFinishedParsing(false)
- , m_forceAsync(!parserInserted)
+ , m_forceAsync(!(constructionContextFlags & ParserInserted))
+ , m_wasCreatedDuringDocumentWrite(constructionContextFlags & CreatedDuringDocumentWrite)
{
ASSERT(m_element);
- if (parserInserted && element->document().scriptableDocumentParser() && !element->document().isInDocumentWrite())
+ if (m_parserInserted && element->document().scriptableDocumentParser() && !element->document().isInDocumentWrite())
m_startLineNumber = element->document().scriptableDocumentParser()->lineNumber();
}

Powered by Google App Engine
This is Rietveld 408576698