Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: net/quic/congestion_control/pacing_sender.h

Issue 1814843002: Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No func… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116887287
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A send algorithm that adds pacing on top of an another send algorithm. 5 // A send algorithm that adds pacing on top of an another send algorithm.
6 // It uses the underlying sender's pacing rate to schedule packets. 6 // It uses the underlying sender's pacing rate to schedule packets.
7 // It also takes into consideration the expected granularity of the underlying 7 // It also takes into consideration the expected granularity of the underlying
8 // alarm to ensure that alarms are not set too aggressively, and err towards 8 // alarm to ensure that alarms are not set too aggressively, and err towards
9 // sending packets too early instead of too late. 9 // sending packets too early instead of too late.
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 QuicByteCount bytes_in_flight, 48 QuicByteCount bytes_in_flight,
49 const CongestionVector& acked_packets, 49 const CongestionVector& acked_packets,
50 const CongestionVector& lost_packets) override; 50 const CongestionVector& lost_packets) override;
51 bool OnPacketSent(QuicTime sent_time, 51 bool OnPacketSent(QuicTime sent_time,
52 QuicByteCount bytes_in_flight, 52 QuicByteCount bytes_in_flight,
53 QuicPacketNumber packet_number, 53 QuicPacketNumber packet_number,
54 QuicByteCount bytes, 54 QuicByteCount bytes,
55 HasRetransmittableData is_retransmittable) override; 55 HasRetransmittableData is_retransmittable) override;
56 void OnRetransmissionTimeout(bool packets_retransmitted) override; 56 void OnRetransmissionTimeout(bool packets_retransmitted) override;
57 void OnConnectionMigration() override; 57 void OnConnectionMigration() override;
58 QuicTime::Delta TimeUntilSend( 58 QuicTime::Delta TimeUntilSend(QuicTime now,
59 QuicTime now, 59 QuicByteCount bytes_in_flight) const override;
60 QuicByteCount bytes_in_flight,
61 HasRetransmittableData has_retransmittable_data) const override;
62 QuicBandwidth PacingRate() const override; 60 QuicBandwidth PacingRate() const override;
63 QuicBandwidth BandwidthEstimate() const override; 61 QuicBandwidth BandwidthEstimate() const override;
64 QuicTime::Delta RetransmissionDelay() const override; 62 QuicTime::Delta RetransmissionDelay() const override;
65 QuicByteCount GetCongestionWindow() const override; 63 QuicByteCount GetCongestionWindow() const override;
66 bool InSlowStart() const override; 64 bool InSlowStart() const override;
67 bool InRecovery() const override; 65 bool InRecovery() const override;
68 QuicByteCount GetSlowStartThreshold() const override; 66 QuicByteCount GetSlowStartThreshold() const override;
69 CongestionControlType GetCongestionControlType() const override; 67 CongestionControlType GetCongestionControlType() const override;
70 // End implementation of SendAlgorithmInterface. 68 // End implementation of SendAlgorithmInterface.
71 69
(...skipping 10 matching lines...) Expand all
82 QuicTime last_delayed_packet_sent_time_; 80 QuicTime last_delayed_packet_sent_time_;
83 QuicTime ideal_next_packet_send_time_; // When can the next packet be sent. 81 QuicTime ideal_next_packet_send_time_; // When can the next packet be sent.
84 mutable bool was_last_send_delayed_; // True when the last send was delayed. 82 mutable bool was_last_send_delayed_; // True when the last send was delayed.
85 83
86 DISALLOW_COPY_AND_ASSIGN(PacingSender); 84 DISALLOW_COPY_AND_ASSIGN(PacingSender);
87 }; 85 };
88 86
89 } // namespace net 87 } // namespace net
90 88
91 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_ 89 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698