Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181483006: PACKET_NBYTE_GUID -> PACKET_NBYTE_CONNECTION_ID (Closed)

Created:
6 years, 10 months ago by ramant (doing other things)
Modified:
6 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

PACKET_NBYTE_GUID -> PACKET_NBYTE_CONNECTION_ID GUID->ConnectionId QuicGuid->QuicConnectionId guid->connection_id except for the dos proto, which I'm leaving alone for now. renaming quic guid to connection id. no functional change. Merge internal change: 62087636 R=rch@chromium.org

Patch Set 1 : small comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+935 lines, -850 lines) Patch
M net/quic/crypto/crypto_handshake.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 9 chunks +17 lines, -13 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 17 chunks +24 lines, -24 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_framer.cc View 12 chunks +68 lines, -58 lines 0 comments Download
M net/quic/quic_framer_test.cc View 164 chunks +315 lines, -306 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 8 chunks +24 lines, -23 lines 0 comments Download
M net/quic/quic_protocol.cc View 7 chunks +25 lines, -22 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_framer_peer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 9 chunks +14 lines, -12 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 4 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 8 chunks +32 lines, -26 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 8 chunks +32 lines, -29 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 7 chunks +62 lines, -57 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 7 chunks +64 lines, -53 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 12 chunks +118 lines, -104 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 3 chunks +7 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 10 months ago (2014-02-27 00:04:03 UTC) #1
Ryan Hamilton
6 years, 10 months ago (2014-02-27 00:29:29 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698