Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 181483005: Rename MediaKeys*Msg to Cdm*Msg. (Closed)

Created:
6 years, 9 months ago by xhwang
Modified:
6 years, 9 months ago
Reviewers:
ddorwin, dcheng
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Rename MediaKeys*Msg to Cdm*Msg. This is the first step to separate CDM messages from MediaPlayer messages. In a follow up CL, CDM messages will be moved to separate files. BUG=315312 R=dcheng@chromium.org, ddorwin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253665

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 5 chunks +11 lines, -12 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 2 chunks +15 lines, -12 lines 0 comments Download
M content/common/media/media_player_messages_enums_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/proxy_media_keys.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 3 chunks +12 lines, -13 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xhwang
dcheng: Please ONWERS review. ddorwin: FYI.
6 years, 9 months ago (2014-02-26 22:53:15 UTC) #1
dcheng
LGTM. Thanks, and sorry for the trouble.
6 years, 9 months ago (2014-02-26 22:54:53 UTC) #2
xhwang
ddorwin: Sorry, I think I also need your review. Renaming only :)
6 years, 9 months ago (2014-02-26 22:57:41 UTC) #3
ddorwin
lgtm
6 years, 9 months ago (2014-02-26 23:05:54 UTC) #4
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 9 months ago (2014-02-26 23:07:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/181483005/20001
6 years, 9 months ago (2014-02-26 23:15:16 UTC) #6
xhwang
6 years, 9 months ago (2014-02-27 00:43:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r253665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698