Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1814823006: [Sync] Accumulate GU response chunks in the Worker. (Closed)

Created:
4 years, 9 months ago by maxbogue
Modified:
4 years, 9 months ago
Reviewers:
Gang Wu, skym, pavely
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mtw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Accumulate GU response chunks in the Worker. This change renames "pending" updates in the worker to "encrypted" updates and repurposes "pending" to refer to the updates being accumulated for sending to the processor. BUG=596232 Committed: https://crrev.com/8cd3afc795cf42b5bbc1edec1e0b93d234558c05 Cr-Commit-Position: refs/heads/master@{#382994}

Patch Set 1 #

Patch Set 2 : Comment tweaks. #

Patch Set 3 : Improve test coverage. #

Total comments: 2

Patch Set 4 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -93 lines) Patch
M sync/engine/model_type_worker.h View 1 3 chunks +27 lines, -20 lines 0 comments Download
M sync/engine/model_type_worker.cc View 1 7 chunks +34 lines, -42 lines 0 comments Download
M sync/engine/model_type_worker_unittest.cc View 1 2 5 chunks +47 lines, -12 lines 0 comments Download
M sync/engine/worker_entity_tracker.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M sync/engine/worker_entity_tracker.cc View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
maxbogue
PTAL!
4 years, 9 months ago (2016-03-21 21:37:35 UTC) #3
skym
lgtm
4 years, 9 months ago (2016-03-21 22:55:07 UTC) #4
pavely
lgtm https://codereview.chromium.org/1814823006/diff/40001/sync/engine/worker_entity_tracker.h File sync/engine/worker_entity_tracker.h (right): https://codereview.chromium.org/1814823006/diff/40001/sync/engine/worker_entity_tracker.h#newcode79 sync/engine/worker_entity_tracker.h:79: // Clears the pending update. Allows us to ...
4 years, 9 months ago (2016-03-23 21:58:15 UTC) #5
maxbogue
https://codereview.chromium.org/1814823006/diff/40001/sync/engine/worker_entity_tracker.h File sync/engine/worker_entity_tracker.h (right): https://codereview.chromium.org/1814823006/diff/40001/sync/engine/worker_entity_tracker.h#newcode79 sync/engine/worker_entity_tracker.h:79: // Clears the pending update. Allows us to resume ...
4 years, 9 months ago (2016-03-23 22:59:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814823006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814823006/60001
4 years, 9 months ago (2016-03-23 22:59:53 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-24 00:45:57 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:47:18 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8cd3afc795cf42b5bbc1edec1e0b93d234558c05
Cr-Commit-Position: refs/heads/master@{#382994}

Powered by Google App Engine
This is Rietveld 408576698