Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1814823005: Remove obsolete isolate from CompareOperation predicate. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete isolate from CompareOperation predicate. This removes the Isolate argument from the IsLiteralCompareUndefined predicate as it is no longer required to determine the answer. R=jkummerow@chromium.org Committed: https://crrev.com/2701e67d1bc7457f6272601fed1efa9720f672a6 Cr-Commit-Position: refs/heads/master@{#34902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M src/ast/ast.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/ast/ast.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-18 16:56:46 UTC) #1
Toon Verwaest
Drive by lgtm. Nice cleanup.
4 years, 9 months ago (2016-03-18 17:00:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814823005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814823005/1
4 years, 9 months ago (2016-03-18 17:14:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 17:19:29 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 17:20:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2701e67d1bc7457f6272601fed1efa9720f672a6
Cr-Commit-Position: refs/heads/master@{#34902}

Powered by Google App Engine
This is Rietveld 408576698