Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1814813003: Collect samples for background threads. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Collect samples for background threads. - Don't tick vm tags for background threads so the Observatory's summary pie chart reflects how the mutator spent its time. - Similarly, don't factor background samples in the CPU profile view. - Do include background samples in the timeline view. Use a different event name for background compilations. Add timeline events for the mark and sweep tasks. Reload the isolate list when refreshing the timeline view so it includes profile ticks when the page is loading directly (e.g., F5) instead of only after visiting the vm page. Fix loading the timeline when profiling is disabled. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/366f1f1ed1c6506e3f2cf5f21da694570f67eff1

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
M runtime/observatory/lib/src/elements/timeline_page.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/web/timeline.js View 1 2 1 chunk +15 lines, -9 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/gc_sweeper.cc View 1 2 2 chunks +27 lines, -23 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.h View 3 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/profiler_service.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M runtime/vm/timeline.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
rmacnak
4 years, 9 months ago (2016-03-17 23:58:38 UTC) #5
Cutch
Nice! LGTM.
4 years, 9 months ago (2016-03-18 13:32:50 UTC) #6
rmacnak
4 years, 9 months ago (2016-03-18 17:18:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
366f1f1ed1c6506e3f2cf5f21da694570f67eff1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698