Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1814763004: Reverting significance level to 0.01 because of some suprious results. (Closed)

Created:
4 years, 9 months ago by RobertoCN
Modified:
4 years, 9 months ago
Reviewers:
sullivan, dtu, qyearsley
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reverting significance level to 0.01 because of some spurious results. e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=594179#c4 R=sullivan,qyearsley,dtu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299371

Patch Set 1 #

Patch Set 2 : Updated expectations, duh. #

Messages

Total messages: 12 (6 generated)
qyearsley
I don't see any problem with this. (Note, there's a minor typo in the title ...
4 years, 9 months ago (2016-03-17 19:57:26 UTC) #1
dtu
lgtm
4 years, 9 months ago (2016-03-17 23:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814763004/1
4 years, 9 months ago (2016-03-17 23:25:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3185)
4 years, 9 months ago (2016-03-17 23:31:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814763004/20001
4 years, 9 months ago (2016-03-18 00:12:44 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:16:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299371

Powered by Google App Engine
This is Rietveld 408576698