Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1814743002: DevTools: fix closure compilation of WI.TargetManager (Closed)

Created:
4 years, 9 months ago by lushnikov
Modified:
4 years, 9 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix closure compilation of WI.TargetManager The compilation was broken due to crrev.com/381594 BUG=none TBR=paulirish, pfeldman Committed: https://crrev.com/a8b4521d387961c6aaa6e3655e04ea0631a94888 Cr-Commit-Position: refs/heads/master@{#381670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lushnikov
4 years, 9 months ago (2016-03-17 06:54:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814743002/1
4 years, 9 months ago (2016-03-17 06:55:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 08:07:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8b4521d387961c6aaa6e3655e04ea0631a94888 Cr-Commit-Position: refs/heads/master@{#381670}
4 years, 9 months ago (2016-03-17 08:09:15 UTC) #6
paulirish
4 years, 9 months ago (2016-03-19 01:23:07 UTC) #7
Message was sent while issue was closed. 
:(
thanks. appreciate it.

Powered by Google App Engine
This is Rietveld 408576698