Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 181473009: Rollback of r19535 in 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Rollback of r19535 in 3.24 branch. Fix for a smi stores optimization on x64 with a regression test. BUG=345715 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regress/regress-crbug-345715.js View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
6 years, 9 months ago (2014-02-27 14:59:53 UTC) #1
Hannes Payer (out of office)
LGTM
6 years, 9 months ago (2014-02-27 15:03:13 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-02-27 15:04:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19582 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698