Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1814723002: Prepare for turning on SDK summaries in Analysis Server. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prepare for turning on SDK summaries in Analysis Server. 1. Move plugins registering before SDK creation so that when SDK creates AnalysisContext and initializes EnginePlugin, all tasks are already registered. 2. Provide additional results which are used by the strong mode. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6eb900838b5d3136308e1b7bade0a0ad04b5ee18

Patch Set 1 #

Patch Set 2 : Set 'true' as value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-17 02:56:28 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-17 13:51:17 UTC) #2
scheglov
4 years, 9 months ago (2016-03-17 15:37:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6eb900838b5d3136308e1b7bade0a0ad04b5ee18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698