ensure_goma for goma canary

ensure_goma for goma canary

for bot configured as goma_canary, it will use head of goma repo,
instead of pinned revision configured in ensure_goma.py

BUG=595234
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299374

[ukai, 2016-03-17 02:57:13]

Description was changed from

==========
ensure_goma for goma canary

for bot configured as goma_canary, it will use head of goma repo,
instead of pinned revision configured in ensure_goma.py

BUG=595234
==========

to

==========
ensure_goma for goma canary

for bot configured as goma_canary, it will use head of goma repo,
instead of pinned revision configured in ensure_goma.py

BUG=595234
==========

[ukai, 2016-03-17 02:57:13]

ukai@chromium.org changed reviewers:
+ iannucci@chromium.org, phajdan.jr@chromium.org

[iannucci, 2016-03-17 03:48:47]

lgtm, though I'd wait for Pawel to look at it

[ukai, 2016-03-17 03:52:32]

On 2016/03/17 03:48:47, iannucci wrote:
> lgtm, though I'd wait for Pawel to look at it

ok. wait for Pawel.

[Paweł Hajdan Jr., 2016-03-17 06:36:34]

LGTM

[ukai, 2016-03-18 00:34:50]

The CQ bit was checked by ukai@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:34:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814713002/1

[commit-bot: I haz the power, 2016-03-18 00:38:38]

Description was changed from

==========
ensure_goma for goma canary

for bot configured as goma_canary, it will use head of goma repo,
instead of pinned revision configured in ensure_goma.py

BUG=595234
==========

to

==========
ensure_goma for goma canary

for bot configured as goma_canary, it will use head of goma repo,
instead of pinned revision configured in ensure_goma.py

BUG=595234

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299374
==========

[commit-bot: I haz the power, 2016-03-18 00:38:39]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299374

[scottmg, 2016-03-18 01:08:46]

On 2016/03/18 00:38:39, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299374

I think this broke all bots. (ensure_goma should be args.canary, not
arg.canary?)

[scottmg, 2016-03-18 01:09:09]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-03-18 01:09:09]

https://codereview.chromium.org/1814713002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/goma/resources/ensure_goma.py (right):

https://codereview.chromium.org/1814713002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/goma/resources/ensure_goma.py:51: if arg.canary:
Here.

[scottmg, 2016-03-18 01:09:36]

On 2016/03/18 01:09:09, scottmg wrote:
>
https://codereview.chromium.org/1814713002/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/goma/resources/ensure_goma.py (right):
> 
>
https://codereview.chromium.org/1814713002/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/goma/resources/ensure_goma.py:51: if arg.canary:
> Here.

For example
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64...

[scottmg, 2016-03-18 01:14:57]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1811953003/ by scottmg@chromium.org.

The reason for reverting is: Seems to have broken most bots, e.g.

https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64...

with

Traceback (most recent call last):
  File "/b/build/scripts/slave/recipe_modules/goma/resources/ensure_goma.py",
line 70, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/build/scripts/slave/recipe_modules/goma/resources/ensure_goma.py",
line 51, in main
    if arg.canary:
NameError: global name 'arg' is not defined.