runtime/vm/flow_graph_compiler_ia32.cc - Issue 18147021: Fix type check elimination bug in code generator (issue 11792).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 18147021: Fix type check elimination bug in code generator (issue 11792). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 24961)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -674,7 +674,7 @@

__ cmpl(EAX, raw_null);

__ j(EQUAL, &is_assignable);

- if (!FLAG_eliminate_type_checks) {

+ if (!FLAG_eliminate_type_checks || dst_type.IsMalformed()) {

// If type checks are not eliminated during the graph building then

// a transition sentinel can be seen here.

const Immediate& raw_transition_sentinel =

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »