Issue 18147009: IndexedDB: Remove unnecessary scoped_refptr<T>::get() calls

Issue 18147009: IndexedDB: Remove unnecessary scoped_refptr<T>::get() calls (Closed)

Created:
7 years, 5 months ago by jsbell

Modified:
7 years, 5 months ago

Reviewers:
dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

IndexedDB: Remove unnecessary scoped_refptr<T>::get() calls scoped_refptr<T> with implicitly cast to T* so most explicit .get() calls can be removed. Most of these are from the Blink migration. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209939

Patch Set 1 #

Patch Set 2 : clang-format #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -124 lines)			Patch
M	content/browser/indexed_db/indexed_db_backing_store.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_backing_store_unittest.cc	View	1	8 chunks	+9 lines, -10 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_browsertest.cc	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_context_impl.cc	View	1	6 chunks	+16 lines, -20 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_database.cc	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_database_unittest.cc	View	1	4 chunks	+7 lines, -16 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_dispatcher_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_factory.cc	View	1	7 chunks	+11 lines, -11 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_internals_ui.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_quota_client.cc	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_quota_client_unittest.cc	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_transaction.h	View	1	1 chunk	+7 lines, -10 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_unittest.cc	View	1	4 chunks	+8 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

Please take a look? (clang-format made a few unrelated layout tweaks)

7 years, 5 months ago (2013-07-02 21:42:04 UTC) #1

jsbell

FYI, I based this on https://codereview.chromium.org/18221003/ so will let that land first.

7 years, 5 months ago (2013-07-02 22:28:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/18147009/2001

7 years, 5 months ago (2013-07-03 05:04:25 UTC) #4

Message was sent while issue was closed.

Change committed as 209939

Expand Messages | Collapse Messages