Restore focus when an automation node becomes invalidated.

Restore focus when an automation node becomes invalidated.

Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get invalidated).

m

BUG=

Committed: https://crrev.com/ca668ad764cdc6bcaa6205f742dd979a7a91737a
Cr-Commit-Position: refs/heads/master@{#381630}

[David Tseng, 2016-03-16 23:32:27]

Description was changed from

==========
Restore focus when an automation node becomes invalidated.

















m

BUG=
==========

to

==========
Restore focus when an automation node becomes invalidated.


Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get
invalidated).
















m

BUG=
==========

[David Tseng, 2016-03-16 23:32:27]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-03-16 23:48:36]

lgtm

https://codereview.chromium.org/1814633002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1814633002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:284:
if (newRange.start.node.role === undefined ||
Consider ending an excursion if necessary?

[David Tseng, 2016-03-17 00:40:11]

https://codereview.chromium.org/1814633002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/1814633002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:284:
if (newRange.start.node.role === undefined ||
On 2016/03/16 23:48:36, dmazzoni wrote:
> Consider ending an excursion if necessary?
> 

I don't think we want this. For example, in an incremental search, if we
navigate to an element that gets destroyed after we set it as a current range,
we still want to stay in excursion, but just move somewhere valid.

[David Tseng, 2016-03-17 00:40:17]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-03-17 00:41:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814633002/1

[commit-bot: I haz the power, 2016-03-17 01:27:08]

Description was changed from

==========
Restore focus when an automation node becomes invalidated.


Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get
invalidated).
















m

BUG=
==========

to

==========
Restore focus when an automation node becomes invalidated.


Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get
invalidated).
















m

BUG=
==========

[commit-bot: I haz the power, 2016-03-17 01:27:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 01:28:18]

Description was changed from

==========
Restore focus when an automation node becomes invalidated.


Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get
invalidated).
















m

BUG=
==========

to

==========
Restore focus when an automation node becomes invalidated.

Examples:
- load a page that takes some time to load (e.g. nytimes.com)
- begin navigating immediately

result:
wrap sound

expected:
to have something focused

- navigate to nfb.org
- navigate to the skip link
- continue navigating

result:
wrap sound

expected:
focus lands somewhere (it appears focusing some elements causes them to get
invalidated).

m

BUG=

Committed: https://crrev.com/ca668ad764cdc6bcaa6205f742dd979a7a91737a
Cr-Commit-Position: refs/heads/master@{#381630}
==========

[commit-bot: I haz the power, 2016-03-17 01:28:19]

Patchset 1 (id:??) landed as
https://crrev.com/ca668ad764cdc6bcaa6205f742dd979a7a91737a
Cr-Commit-Position: refs/heads/master@{#381630}