Issue 181463007: Moving a preexisting DCHECK to a new and more helpful dfatal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181463007: Moving a preexisting DCHECK to a new and more helpful dfatal. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)

Modified:
6 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Moving a preexisting DCHECK to a new and more helpful dfatal. Merge internal change: 62089588 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	net/quic/quic_connection.cc	View		2 chunks	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/181463007/diff/1/net/quic/quic_connection.cc File net/quic/quic_connection.cc (right): https://codereview.chromium.org/181463007/diff/1/net/quic/quic_connection.cc#newcode1639 net/quic/quic_connection.cc:1639: LOG(DFATAL) << "Error: attempt to close an already ...

6 years, 9 months ago (2014-02-27 00:30:53 UTC) #2

ramant (doing other things)

6 years, 9 months ago (2014-02-27 01:05:12 UTC) #3

https://codereview.chromium.org/181463007/diff/1/net/quic/quic_connection.cc
File net/quic/quic_connection.cc (right):

https://codereview.chromium.org/181463007/diff/1/net/quic/quic_connection.cc#...
net/quic/quic_connection.cc:1639: LOG(DFATAL) << "Error: attempt to close an
already closed connection"
On 2014/02/27 00:30:53, Ryan Hamilton wrote:
> nit: I'd switch this to DLOG

Fixed in Patch set of https://codereview.chromium.org/182523002/#ps20001

Done.

Expand Messages | Collapse Messages