Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: runtime/vm/raw_object.cc

Issue 1814623003: Remove Code::active_instructions_. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.cc
diff --git a/runtime/vm/raw_object.cc b/runtime/vm/raw_object.cc
index d32b5abf8771f8d5bc1f9cb28092409c0f17534c..7388f82c6ebe285ea0967728908747cc3930f0c7 100644
--- a/runtime/vm/raw_object.cc
+++ b/runtime/vm/raw_object.cc
@@ -542,6 +542,7 @@ intptr_t RawCode::VisitCodePointers(RawCode* raw_obj,
RawCode* obj = raw_obj->ptr();
intptr_t length = Code::PtrOffBits::decode(obj->state_bits_);
+#if defined(TARGET_ARCH_IA32)
Florian Schneider 2016/03/19 09:51:47 Maybe add a comment why this is only needed on ia3
rmacnak 2016/03/21 17:48:48 Done.
if (Code::AliveBit::decode(obj->state_bits_)) {
// Also visit all the embedded pointers in the corresponding instructions.
uword entry_point = reinterpret_cast<uword>(obj->instructions_->ptr()) +
@@ -553,6 +554,10 @@ intptr_t RawCode::VisitCodePointers(RawCode* raw_obj,
}
}
return Code::InstanceSize(length);
+#else
+ ASSERT(length == 0);
+ return Code::InstanceSize(0);
+#endif
}
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698