Remove Code::active_instructions_.

Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test if the active entry point matches the Instruction's entry point. A Code's entry point is either for its own Instructions or Instructions of stub code in the VM isolate, so we don't need this field to keep the Instructions alive.

precompiled dart2js x64 22254552 -> 22165795 (-0.39%)

BUG=http://dartbug.com/25992
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/714027a81bdcad457c4b83164c3f7076b6e69dfc

[rmacnak, 2016-03-17 00:00:27]

Description was changed from

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the instructions entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

BUG=http://dartbug.com/25992
==========

to

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the Instruction's entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

BUG=http://dartbug.com/25992
==========

[rmacnak, 2016-03-17 00:03:40]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[rmacnak, 2016-03-17 23:34:29]

rmacnak@google.com changed reviewers:
+ srdjan@google.com

[Florian Schneider, 2016-03-19 09:51:47]

lgtm

https://codereview.chromium.org/1814623003/diff/1/runtime/vm/raw_object.cc
File runtime/vm/raw_object.cc (right):

https://codereview.chromium.org/1814623003/diff/1/runtime/vm/raw_object.cc#ne...
runtime/vm/raw_object.cc:545: #if defined(TARGET_ARCH_IA32)
Maybe add a comment why this is only needed on ia32.

[rmacnak, 2016-03-21 17:48:48]

https://codereview.chromium.org/1814623003/diff/1/runtime/vm/raw_object.cc
File runtime/vm/raw_object.cc (right):

https://codereview.chromium.org/1814623003/diff/1/runtime/vm/raw_object.cc#ne...
runtime/vm/raw_object.cc:545: #if defined(TARGET_ARCH_IA32)
On 2016/03/19 09:51:47, Florian Schneider wrote:
> Maybe add a comment why this is only needed on ia32.

Done.

[rmacnak, 2016-03-21 17:53:05]

Description was changed from

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the Instruction's entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

BUG=http://dartbug.com/25992
==========

to

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the Instruction's entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

precompiled dart2js x64 22254552 -> 22165795 (-0.39%)

BUG=http://dartbug.com/25992
==========

[rmacnak, 2016-03-21 17:53:35]

Description was changed from

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the Instruction's entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

precompiled dart2js x64 22254552 -> 22165795 (-0.39%)

BUG=http://dartbug.com/25992
==========

to

==========
Remove Code::active_instructions_.

It is only used to test if the Code has been disabled, and we can instead test
if the active entry point matches the Instruction's entry point. A Code's entry
point is either for its own Instructions or Instructions of stub code in the VM
isolate, so we don't need this field to keep the Instructions alive.

precompiled dart2js x64 22254552 -> 22165795 (-0.39%)

BUG=http://dartbug.com/25992
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/714027a81bdcad457c4b83164c3f7076b6e69dfc
==========

[rmacnak, 2016-03-21 17:53:36]

Committed patchset #2 (id:20001) manually as
714027a81bdcad457c4b83164c3f7076b6e69dfc (presubmit successful).