Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 1814593002: [Android] Renable ContextMenuTest and SelectFileDialogTest disabled due to permissions issues. (Closed)

Created:
4 years, 9 months ago by rnephew (Reviews Here)
Modified:
4 years, 9 months ago
Reviewers:
Ted C, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Renable ContextMenuTest and SelectFileDialogTest disabled due to permissions issues. Should be fixed with https://codereview.chromium.org/1800283002/ BUG=592594, 592627, 591224 Committed: https://crrev.com/389eae98c8534ef24576d0929c94b81b9ca02857 Cr-Commit-Position: refs/heads/master@{#381750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/SelectFileDialogTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rnephew (Reviews Here)
I think this should be the last ones that were disabled. The rest of the ...
4 years, 9 months ago (2016-03-16 22:04:59 UTC) #2
jbudorick
lgtm
4 years, 9 months ago (2016-03-16 22:05:32 UTC) #3
Ted C
lgtm
4 years, 9 months ago (2016-03-17 17:52:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814593002/1
4 years, 9 months ago (2016-03-17 18:16:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 18:22:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:24:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/389eae98c8534ef24576d0929c94b81b9ca02857
Cr-Commit-Position: refs/heads/master@{#381750}

Powered by Google App Engine
This is Rietveld 408576698