third_party/WebKit/Source/core/fetch/ImageResource.cpp - Issue 1814563002: wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1814563002: wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/CharacterData.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | third_party/WebKit/Source/wtf/CheckedNumeric.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

index caaac704bf2695a5c38c3c53dec4c1098c0ea789..470931fcf532bca1b5dfb72dd41098d5e6ea44f0 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

@@ -381,9 +381,9 @@ void ImageResource::decodedSizeChanged(const blink::Image* image, int delta)

if (!image || image != m_image)

return;

- // TODO(bsep): Crash on underflow, which is possible if an error causes

- // decodedSize to be 0.

- setDecodedSize(decodedSize() + delta);

+ WTF::CheckedNumeric<size_t> checkedDecodedSize(decodedSize());

+ checkedDecodedSize += delta;

+ setDecodedSize(checkedDecodedSize.ValueOrDie());

}

void ImageResource::didDraw(const blink::Image* image)