Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart

Issue 1814553002: Motown: Improvements to packet definition (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Added a comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/services/media/common/interfaces/media_transport.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart
diff --git a/mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart b/mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart
index b36f0f5029a02845907985a0561a5e3bfed3091e..c8ffc41e4e217712e466eb2e05238b9a11e7cc6b 100644
--- a/mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart
+++ b/mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart
@@ -100,11 +100,10 @@ class MediaPacketRegion extends bindings.Struct {
class MediaPacket extends bindings.Struct {
static const List<bindings.StructDataHeader> kVersions = const [
- const bindings.StructDataHeader(48, 0)
+ const bindings.StructDataHeader(40, 0)
];
static const int kNoTimestamp = 9223372036854775807;
int pts = 9223372036854775807;
- int duration = 0;
bool endOfStream = false;
MediaPacketRegion payload = null;
List<MediaPacketRegion> extraPayload = null;
@@ -150,20 +149,16 @@ class MediaPacket extends bindings.Struct {
}
if (mainDataHeader.version >= 0) {
- result.duration = decoder0.decodeUint64(16);
+ result.endOfStream = decoder0.decodeBool(16, 0);
}
if (mainDataHeader.version >= 0) {
- result.endOfStream = decoder0.decodeBool(24, 0);
- }
- if (mainDataHeader.version >= 0) {
-
- var decoder1 = decoder0.decodePointer(32, false);
+ var decoder1 = decoder0.decodePointer(24, false);
result.payload = MediaPacketRegion.decode(decoder1);
}
if (mainDataHeader.version >= 0) {
- var decoder1 = decoder0.decodePointer(40, true);
+ var decoder1 = decoder0.decodePointer(32, true);
if (decoder1 == null) {
result.extraPayload = null;
} else {
@@ -189,21 +184,14 @@ class MediaPacket extends bindings.Struct {
rethrow;
}
try {
- encoder0.encodeUint64(duration, 16);
- } on bindings.MojoCodecError catch(e) {
- e.message = "Error encountered while encoding field "
- "duration of struct MediaPacket: $e";
- rethrow;
- }
- try {
- encoder0.encodeBool(endOfStream, 24, 0);
+ encoder0.encodeBool(endOfStream, 16, 0);
} on bindings.MojoCodecError catch(e) {
e.message = "Error encountered while encoding field "
"endOfStream of struct MediaPacket: $e";
rethrow;
}
try {
- encoder0.encodeStruct(payload, 32, false);
+ encoder0.encodeStruct(payload, 24, false);
} on bindings.MojoCodecError catch(e) {
e.message = "Error encountered while encoding field "
"payload of struct MediaPacket: $e";
@@ -211,9 +199,9 @@ class MediaPacket extends bindings.Struct {
}
try {
if (extraPayload == null) {
- encoder0.encodeNullPointer(40, true);
+ encoder0.encodeNullPointer(32, true);
} else {
- var encoder1 = encoder0.encodePointerArray(extraPayload.length, 40, bindings.kUnspecifiedArrayLength);
+ var encoder1 = encoder0.encodePointerArray(extraPayload.length, 32, bindings.kUnspecifiedArrayLength);
for (int i0 = 0; i0 < extraPayload.length; ++i0) {
encoder1.encodeStruct(extraPayload[i0], bindings.ArrayDataHeader.kHeaderSize + bindings.kPointerSize * i0, false);
}
@@ -228,7 +216,6 @@ class MediaPacket extends bindings.Struct {
String toString() {
return "MediaPacket("
"pts: $pts" ", "
- "duration: $duration" ", "
"endOfStream: $endOfStream" ", "
"payload: $payload" ", "
"extraPayload: $extraPayload" ")";
@@ -237,7 +224,6 @@ class MediaPacket extends bindings.Struct {
Map toJson() {
Map map = new Map();
map["pts"] = pts;
- map["duration"] = duration;
map["endOfStream"] = endOfStream;
map["payload"] = payload;
map["extraPayload"] = extraPayload;
« no previous file with comments | « no previous file | mojo/services/media/common/interfaces/media_transport.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698