Motown: Improvements to packet definition

services/media/framework_ffmpeg/av_packet.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_MEDIA_FRAMEWORK_FFMPEG_AV_PACKET_H_
+#define SERVICES_MEDIA_FRAMEWORK_FFMPEG_AV_PACKET_H_
+
+extern "C" {
+#include "third_party/ffmpeg/libavcodec/avcodec.h"
+#include "third_party/ffmpeg/libavformat/avformat.h"
+}
+
+namespace mojo {
+namespace media {

[johngro, 2016/03/21 19:47:56]

just a suggestion (take it or leave it); As these helpers (AVFrame, AVPacket,
etc) are specific to FFmpeg, and use some of the same terminology which we use
elsewhere (we also call access-unit-like things "packets") we might want to
stuff these definitions into a mojo::media::ffmpeg namespace.

[dalesat, 2016/03/21 22:30:59]

Done.

+
+struct AVPacketDeleter {
+  inline void operator()(AVPacket* ptr) const {
+    av_free_packet(ptr);
+  }
+};
+
+using AvPacketPtr = std::unique_ptr<AVPacket, AVPacketDeleter>;
+
+struct AvPacket{
+  static AvPacketPtr Create() {
+    AVPacket* av_packet = new AVPacket();
+    av_init_packet(av_packet);
+    return AvPacketPtr(av_packet);
+  }
+};
+
+}  // namespace media
+}  // namespace mojo
+
+#endif // SERVICES_MEDIA_FRAMEWORK_FFMPEG_AV_PACKET_H_