Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1814533003: Revert of sRGB support in Ganesh. Several pieces: (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of sRGB support in Ganesh. Several pieces: (patchset #12 id:220001 of https://codereview.chromium.org/1789663002/ ) Reason for revert: We're getting sRGB non-8888 configs? Original issue's description: > sRGB support in Ganesh. Several pieces: > > sRGB support now also requires GL_EXT_texture_sRGB_decode, which allows > us to disable sRGB -> Linear conversion when reading textures. This gives > us an easy way to support "legacy" L32 mode. We disable decoding based on > the pixel config of the render target. Textures can override that behavior > (specifically for format-conversion draws where we want that behavior). > > Added sBGRA pixel config, which is not-really-a-format. It's just sRGBA > internally, and the external format is BGR order, so TexImage calls will > swizzle correctly. This lets us interact with sRGB raster surfaces on BGR > platforms. > > Devices without sRGB support behave like they always have: conversion from > color type and profile type ignores sRGB and always returns linear pixel > configs. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1789663002 > > Committed: https://skia.googlesource.com/skia/+/9e3f1bf4e5cd8fc59554f986f36d6b034e99f9eb TBR=reed@google.com,bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c571c001cee4e0dfacd7bd17d5cd0a2900a853a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -235 lines) Patch
M example/HelloWorld.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrCaps.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrColor.h View 3 chunks +8 lines, -9 lines 0 comments Download
M include/gpu/GrTextureParams.h View 7 chunks +1 line, -30 lines 0 comments Download
M include/gpu/GrTypes.h View 7 chunks +0 lines, -23 lines 0 comments Download
M include/gpu/SkGr.h View 2 chunks +3 lines, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/GrCaps.cpp View 4 chunks +7 lines, -11 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/SkGr.cpp View 7 chunks +29 lines, -42 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +7 lines, -36 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 6 chunks +4 lines, -31 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Osman
Created Revert of sRGB support in Ganesh. Several pieces:
4 years, 9 months ago (2016-03-17 20:01:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814533003/1
4 years, 9 months ago (2016-03-17 20:01:12 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 20:01:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c571c001cee4e0dfacd7bd17d5cd0a2900a853a9

Powered by Google App Engine
This is Rietveld 408576698