Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/ui/signin_view_controller_delegate.cc

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/signin_view_controller_delegate.cc
diff --git a/chrome/browser/ui/signin_view_controller_delegate.cc b/chrome/browser/ui/signin_view_controller_delegate.cc
index 86ea51762aca517bfb9cb3851a0f5d2b77812d79..f923845db3776ba75f0830b21179db8c59972b74 100644
--- a/chrome/browser/ui/signin_view_controller_delegate.cc
+++ b/chrome/browser/ui/signin_view_controller_delegate.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/signin_view_controller_delegate.h"
#include "base/bind.h"
+#include "base/values.h"
#include "chrome/browser/ui/signin_view_controller.h"
#include "chrome/browser/ui/webui/signin/get_auth_frame.h"
#include "content/public/browser/web_contents.h"
@@ -24,10 +25,6 @@ SigninViewControllerDelegate::SigninViewControllerDelegate(
: signin_view_controller_(signin_view_controller),
web_contents_(web_contents) {
web_contents_->SetDelegate(this);
- web_contents_->GetWebUI()->RegisterMessageCallback(
- "navigationButtonClicked",
- base::Bind(&SigninViewControllerDelegate::HandleNavigationButtonClicked,
- base::Unretained(this)));
}
SigninViewControllerDelegate::~SigninViewControllerDelegate() {}
@@ -60,8 +57,7 @@ void SigninViewControllerDelegate::LoadingStateChanged(
source->GetWebUI()->CallJavascriptFunction("inline.login.showCloseButton");
}
-void SigninViewControllerDelegate::HandleNavigationButtonClicked(
- const base::ListValue* args) {
+void SigninViewControllerDelegate::PerformNavigation() {
if (CanGoBack(web_contents_)) {
auto auth_web_contents = GetAuthFrameWebContents(web_contents_);
auth_web_contents->GetController().GoBack();

Powered by Google App Engine
This is Rietveld 408576698