chrome/browser/resources/sync_confirmation/sync_confirmation.js - Issue 1814513002: Fix sizing issues in the tab modal signin flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.js

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address documentation-related feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/sync_confirmation/sync_confirmation.js

diff --git a/chrome/browser/resources/sync_confirmation/sync_confirmation.js b/chrome/browser/resources/sync_confirmation/sync_confirmation.js

index dca1b5877b1816dfc0091a57e0c574d1dc1648d8..447201bfd6fede5edf4a80e45cbffa453033c1f0 100644

--- a/chrome/browser/resources/sync_confirmation/sync_confirmation.js

+++ b/chrome/browser/resources/sync_confirmation/sync_confirmation.js

@@ -23,6 +23,7 @@ cr.define('sync.confirmation', function() {

$('settingsLink').addEventListener('click', onGoToSettings);

$('profile-picture').addEventListener('load', onPictureLoaded);

chrome.send('initialized');

+ chrome.send('resizeNativeView', [document.body.scrollHeight]);

Dan Beam 2016/04/05 06:42:41 nit: why do you need both 'initialized' and 'resiz

anthonyvd 2016/04/05 14:24:48 Good point, they don't need to be separate. Done.

}

function setUserImageURL(url) {