chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm - Issue 1814513002: Fix sizing issues in the tab modal signin flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.css ('K') | « chrome/browser/resources/sync_confirmation/sync_confirmation.css ('k') | chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

diff --git a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

index 08be568ef565ab67d8cf2db41030872993d65958..6fad3107d2da9b141efd7c537d0cb13d310b6d3d 100644

--- a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

+++ b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm

@@ -27,7 +27,7 @@ const CGFloat kPasswordCombinedFixedGaiaViewWidth = 360;

// Dimensions of the tab-modal dialog displaying the password-separated signin

// flow. These match the dimensions of the server content they display.

-const CGFloat kFixedGaiaViewHeight = 512;

+const CGFloat kFixedGaiaViewHeight = 612;

const CGFloat kFixedGaiaViewWidth = 448;

// Dimensions of the sync confirmation tab-modal dialog. These are taken from