Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18145008: Remove Tools/ImageDiff folder which has only qt/gtk/efl implementations left. (Closed)

Created:
7 years, 5 months ago by ostap
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove Tools/ImageDiff folder which has only qt/gtk/efl implementations left. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -752 lines) Patch
D Tools/ImageDiff/efl/ImageDiff.cpp View 1 chunk +0 lines, -368 lines 0 comments Download
D Tools/ImageDiff/gtk/ImageDiff.cpp View 1 chunk +0 lines, -240 lines 0 comments Download
D Tools/ImageDiff/qt/ImageDiff.cpp View 1 chunk +0 lines, -144 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ostap
Remove remains for efl/qt/gtk ImageDiff.
7 years, 5 months ago (2013-07-05 06:30:31 UTC) #1
ojan
lgtm
7 years, 5 months ago (2013-07-05 19:00:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/18145008/1
7 years, 5 months ago (2013-07-05 19:00:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/18145008/1
7 years, 5 months ago (2013-07-05 19:02:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2978
7 years, 5 months ago (2013-07-05 19:16:16 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-09 07:11:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/18145008/1
7 years, 5 months ago (2013-07-09 15:54:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=15489
7 years, 5 months ago (2013-07-09 16:39:44 UTC) #8
ostap
On 2013/07/09 16:39:44, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 5 months ago (2013-07-09 16:45:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/18145008/1
7 years, 5 months ago (2013-07-09 16:45:58 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 18:53:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 153796

Powered by Google App Engine
This is Rietveld 408576698