Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1814493002: Attempt to fix flaky service test debug build failures (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
turnidge, srdjan
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Attempt to fix flaky service test debug build failures Occasional failures like the following: https://build.chromium.org/p/client.dart/builders/vm-win-debug-ia32-be/builds/308/steps/checked%20vm%20tests/logs/stdio Started after I started to report isolate's paused at start if they *will* pause on start. Committed: https://github.com/dart-lang/sdk/commit/d8cddfd2a7819671a0569a65d9e9d749fd6ad908

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M runtime/vm/service_event.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Cutch
4 years, 9 months ago (2016-03-16 20:45:42 UTC) #4
Cutch
TBR
4 years, 9 months ago (2016-03-16 22:02:56 UTC) #6
Cutch
4 years, 9 months ago (2016-03-16 22:03:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d8cddfd2a7819671a0569a65d9e9d749fd6ad908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698