Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1814453002: Remove more calls to safelyVisit methods (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove more calls to safelyVisit methods checkpoint BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9b0fcd3a393af3f9435a40014e42bbc9f9710a6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -113 lines) Patch
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 4 chunks +7 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +3 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 39 chunks +65 lines, -87 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-16 18:22:39 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-16 18:24:32 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-16 18:25:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b0fcd3a393af3f9435a40014e42bbc9f9710a6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698