Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1814443002: Revert of RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled... (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
Reviewers:
esprehn, rmcilroy
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending (patchset #2 id:20001 of https://codereview.chromium.org/1808643003/ ) Reason for revert: Closed tree. Original issue's description: > RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending > > Ensure that ScriptedIdleTaskController does not get unnecessarily retained by a cancelled timeout task if the > idle task has been triggered, but the document has gone away. > > BUG=595155 > > Committed: https://crrev.com/82f18cd2a7b718c4d5356222017d9855a53eb6f3 > Cr-Commit-Position: refs/heads/master@{#381489} TBR=esprehn@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595155 Committed: https://crrev.com/652dd3c14876e7b3618742e829d7b3c5522aaf2e Cr-Commit-Position: refs/heads/master@{#381497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
fgorski
Created Revert of RequestIdleCallback: Avoid retaining ScriptedIdleTaskController while a cancelled timeout is pending
4 years, 9 months ago (2016-03-16 18:14:09 UTC) #1
fgorski
4 years, 9 months ago (2016-03-16 18:30:09 UTC) #3
Message was sent while issue was closed.
Here is a link to bot failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Powered by Google App Engine
This is Rietveld 408576698