Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1814433002: Revert of [crankshaft] Fixing ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [crankshaft] Fixing ES6 tail call elimination. (patchset #7 id:200001 of https://codereview.chromium.org/1780043004/ ) Reason for revert: [Sheriff] Leads to mac gc stress crashes: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/4975 Original issue's description: > [crankshaft] Fixing ES6 tail call elimination. > > In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. > Otherwise we will see G in a stack trace inside H. > > This CL also enables all existing tests related to ES6 tail call elimination. > > TBR=bmeurer@chromium.org > BUG=v8:4698 > LOG=N > > Committed: https://crrev.com/689980f7d4dfd4c29492f616d7b616b86ec9af91 > Cr-Commit-Position: refs/heads/master@{#34830} TBR=mstarzinger@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4698 Committed: https://crrev.com/d64b41ded60d46114640f1473dfe9c48e8a1ccde Cr-Commit-Position: refs/heads/master@{#34835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -336 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 4 chunks +14 lines, -28 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 3 chunks +14 lines, -28 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 16 chunks +39 lines, -48 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 7 chunks +20 lines, -51 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +1 line, -17 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 4 chunks +13 lines, -28 lines 0 comments Download
M src/crankshaft/lithium.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 4 chunks +14 lines, -28 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 4 chunks +14 lines, -28 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 4 chunks +13 lines, -28 lines 0 comments Download
M test/mjsunit/es6/tail-call.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard0.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard1.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard2.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard3.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard4.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard5.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard6.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard7.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard8.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest-shard9.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-simple.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [crankshaft] Fixing ES6 tail call elimination.
4 years, 9 months ago (2016-03-16 18:11:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814433002/1
4 years, 9 months ago (2016-03-16 18:12:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 18:12:21 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 18:13:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d64b41ded60d46114640f1473dfe9c48e8a1ccde
Cr-Commit-Position: refs/heads/master@{#34835}

Powered by Google App Engine
This is Rietveld 408576698