Source/core/rendering/svg/SVGTextRunRenderingContext.cpp - Issue 181443002: Use glyph-ids for lookups of SVG font kerning-pairs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

Issue 181443002: Use glyph-ids for lookups of SVG font kerning-pairs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Vector<...>::append -> Vector<...>::appendVector. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

diff --git a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

index c48c91e2486eb3ed6843fd5a27cec45faa9027ed..2906739ad84cdd5b46a75d1248229d40196c55fa 100644

--- a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

+++ b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

@@ -73,12 +73,12 @@ static inline RenderSVGResource* activePaintingResourceFromRun(const TextRun& ru

return 0;

}

-float SVGTextRunRenderingContext::floatWidthUsingSVGFont(const Font& font, const TextRun& run, int& charsConsumed, String& glyphName) const

+float SVGTextRunRenderingContext::floatWidthUsingSVGFont(const Font& font, const TextRun& run, int& charsConsumed, Glyph& glyphId) const

{

WidthIterator it(&font, run);

GlyphBuffer glyphBuffer;

charsConsumed += it.advance(run.length(), &glyphBuffer);

- glyphName = it.lastGlyphName();

+ glyphId = !glyphBuffer.isEmpty() ? glyphBuffer.glyphAt(0) : 0;

return it.runWidthSoFar();

}