Source/core/rendering/svg/SVGTextMetricsBuilder.cpp - Issue 181443002: Use glyph-ids for lookups of SVG font kerning-pairs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

Issue 181443002: Use glyph-ids for lookups of SVG font kerning-pairs (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Vector<...>::append -> Vector<...>::appendVector. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

diff --git a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

index 55dc71f7ab71e0af722c755874900b889f7cfeea..65ceb8ca851edaf50b7ccf8fedc4d087cd89cfec 100644

--- a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

+++ b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

@@ -67,11 +67,8 @@ void SVGTextMetricsBuilder::advanceSimpleText()

float currentWidth = m_simpleWidthIterator->runWidthSoFar() - m_totalWidth;

m_totalWidth = m_simpleWidthIterator->runWidthSoFar();

-#if ENABLE(SVG_FONTS)

- m_currentMetrics = SVGTextMetrics(m_text, m_textPosition, metricsLength, currentWidth, m_simpleWidthIterator->lastGlyphName());

-#else

- m_currentMetrics = SVGTextMetrics(m_text, m_textPosition, metricsLength, currentWidth, emptyString());

-#endif

+ Glyph glyphId = glyphBuffer.glyphAt(0);

+ m_currentMetrics = SVGTextMetrics(m_text, m_textPosition, metricsLength, currentWidth, glyphId);

}

void SVGTextMetricsBuilder::advanceComplexText()