Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7656)

Unified Diff: build/config/BUILD.gn

Issue 1814423002: Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix conditional for DCheckDumpWithoutCrashing Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/logging.cc ('K') | « base/logging.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index cfa910d3eeea22710778e7abb96255e7224d2aa3..3bba5a4ac453a0c7f8da387541967b2d26d5617c 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -87,6 +87,14 @@ config("feature_flags") {
if (use_browser_spellchecker) {
defines += [ "USE_BROWSER_SPELLCHECKER=1" ]
}
+
+ # In Windows official builds, enable DCHECKs to dump-without-crashing.
Nico 2016/03/20 23:10:40 windows official builds are still built with gyp,
Wez 2016/03/23 04:18:13 Acknowledged. Added some ugly GYP hackery.
+ # See crbug.com/596231.
+ if (is_official_build && is_win) {
+ dcheck_always_on = true
+ defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
+ }
+
if (dcheck_always_on) {
defines += [ "DCHECK_ALWAYS_ON=1" ]
}
« base/logging.cc ('K') | « base/logging.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698