Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: build/common.gypi

Issue 1814423002: Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging_unittest.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ecf711f3c54a2aa734b0f3194b4e056a8cd08458..3086551ed01791466c6a5bb9f75c0ca6e33591f5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -722,6 +722,15 @@
'optimize_jni_generation%': 1,
'conditions': [
+ # In Windows official builds, enable DCHECK as dump-without-crashing.
+ ['OS=="win" and buildtype=="Official"', {
+ 'dcheck_always_on%': 1,
+ 'dcheck_is_dump_without_crash': 1,
+ }, {
+ 'dcheck_always_on%': 0,
+ 'dcheck_is_dump_without_crash': 0,
+ }],
+
# A flag for POSIX platforms
['OS=="win"', {
'os_posix%': 0,
@@ -1193,6 +1202,7 @@
'fastbuild%': '<(fastbuild)',
'win_z7%': '<(win_z7)',
'dcheck_always_on%': '<(dcheck_always_on)',
+ 'dcheck_is_dump_without_crash%': '<(dcheck_is_dump_without_crash)',
'tracing_like_official_build%': '<(tracing_like_official_build)',
'fieldtrial_testing_like_official_build%': '<(fieldtrial_testing_like_official_build)',
'arm_version%': '<(arm_version)',
@@ -2849,6 +2859,9 @@
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
}], # dcheck_always_on!=0
+ ['dcheck_is_dump_without_crash!=0', {
+ 'defines': ['DCHECK_IS_DUMP_WITHOUT_CRASH=1'],
+ }], # dcheck_is_dump_without_crash!=0
['tracing_like_official_build!=0', {
'defines': ['TRACING_IS_OFFICIAL_BUILD=1'],
}], # tracing_like_official_build!=0
« no previous file with comments | « base/logging_unittest.cc ('k') | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698