base/debug/dump_without_crashing.cc - Issue 1814423002: Patch to try dump-on-DCHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/dump_without_crashing.cc

Issue 1814423002: Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/dump_without_crashing.cc

diff --git a/base/debug/dump_without_crashing.cc b/base/debug/dump_without_crashing.cc

index 47fd873c19fd084c51d5e48455db040269ca47b3..4b338ca2930b69d110fd545176029aec75f9cd4a 100644

--- a/base/debug/dump_without_crashing.cc

+++ b/base/debug/dump_without_crashing.cc

@@ -18,9 +18,12 @@ namespace base {

namespace debug {

-void DumpWithoutCrashing() {

- if (dump_without_crashing_function_)

+bool DumpWithoutCrashing() {

+ if (dump_without_crashing_function_) {

(*dump_without_crashing_function_)();

+ return true;

+ }

+ return false;

}

void SetDumpWithoutCrashingFunction(void (CDECL *function)()) {

« no previous file with comments | « base/debug/dump_without_crashing.h ('k') | base/logging.h » ('j') | no next file with comments »