Patch to try dump-on-DCHECK.

base/logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 
 #include <limits.h>
 #include <stdint.h>
 
 #include "base/macros.h"
@@ skipping 43 matching lines @@
 #include <cstring>
 #include <ctime>
 #include <iomanip>
 #include <ostream>
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
 #include "base/debug/debugger.h"
+#if defined(OFFICIAL_BUILD)

[scottmg, 2016/03/21 17:28:12]

Remove the #if here.

[Wez, 2016/03/23 04:18:13]

You prefer to include even if it won't be used?

Done.

+#include "base/debug/dump_without_crashing.h"
+#endif
 #include "base/debug/stack_trace.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock_impl.h"
 #include "base/threading/platform_thread.h"
 #include "base/vlog.h"
@@ skipping 254 matching lines @@
 void CloseLogFileUnlocked() {
   if (!g_log_file)
     return;
 
   CloseFile(g_log_file);
   g_log_file = nullptr;
 }
 
 }  // namespace
 
+#if defined(DCHECK_IS_DUMP_WITHOUT_CRASH)
+// Used to implement dump-on-DCHECK. See crbug.com/596231.
+void DCheckDumpWithoutCrashing() {
+  // To ensure we don't risk spamming Crash with dump-on-DCHECK reports we
+  // log only the first DCHECK to fail once DumpWithoutCrashing() is working.
+  static bool dump_on_dcheck = true;

[Nico, 2016/03/20 23:10:40]

this is racy (doubt it matters though)

[Wez, 2016/03/23 04:18:13]

Extended comment to clarify that yes, that's understood & acceptable.

+  if (dump_on_dcheck)
+    dump_on_dcheck = !base::debug::DumpWithoutCrashing();

[Nico, 2016/03/20 23:10:40]

for stacks in renderer processes, this will dump once per renderer process, not
once total. is that what you want?

[Wez, 2016/03/23 04:18:13]

Yes. Extended comment should make that clearer.

+}
+#endif
+
 LoggingSettings::LoggingSettings()
     : logging_dest(LOG_DEFAULT),
       log_file(nullptr),
       lock_log(LOCK_LOG_FILE),
       delete_old(APPEND_TO_OLD_LOG_FILE) {}
 
 bool BaseInitLoggingImpl(const LoggingSettings& settings) {
 #if defined(OS_NACL)
   // Can log only to the system debug log.
   CHECK_EQ(settings.logging_dest & ~LOG_TO_SYSTEM_DEBUG_LOG, 0);
@@ skipping 562 matching lines @@
 BASE_EXPORT void LogErrorNotReached(const char* file, int line) {
   LogMessage(file, line, LOG_ERROR).stream()
       << "NOTREACHED() hit.";
 }
 
 }  // namespace logging
 
 std::ostream& std::operator<<(std::ostream& out, const wchar_t* wstr) {
   return out << (wstr ? base::WideToUTF8(wstr) : std::string());
 }