Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: build/config/BUILD.gn

Issue 1814423002: Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only build for Win official Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« base/logging.h ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/features.gni") 9 import("//build/config/features.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 # Can be defined without ENABLE_BASIC_PRINTING. 80 # Can be defined without ENABLE_BASIC_PRINTING.
81 defines += [ "ENABLE_PRINT_PREVIEW=1" ] 81 defines += [ "ENABLE_PRINT_PREVIEW=1" ]
82 } 82 }
83 } 83 }
84 if (enable_spellcheck) { 84 if (enable_spellcheck) {
85 defines += [ "ENABLE_SPELLCHECK=1" ] 85 defines += [ "ENABLE_SPELLCHECK=1" ]
86 } 86 }
87 if (use_browser_spellchecker) { 87 if (use_browser_spellchecker) {
88 defines += [ "USE_BROWSER_SPELLCHECKER=1" ] 88 defines += [ "USE_BROWSER_SPELLCHECKER=1" ]
89 } 89 }
90
91 # In Windows official builds, this will cause DCHECKs to
92 # dump-without-crashing. See crbug.com/596231.
93 if (is_official_build && is_win) {
94 dcheck_always_on = true
95 defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
96 }
97
90 if (dcheck_always_on) { 98 if (dcheck_always_on) {
91 defines += [ "DCHECK_ALWAYS_ON=1" ] 99 defines += [ "DCHECK_ALWAYS_ON=1" ]
92 } 100 }
93 if (use_udev) { 101 if (use_udev) {
94 # TODO(brettw) should probably be "=1". 102 # TODO(brettw) should probably be "=1".
95 defines += [ "USE_UDEV" ] 103 defines += [ "USE_UDEV" ]
96 } 104 }
97 if (ui_compositor_image_transport) { 105 if (ui_compositor_image_transport) {
98 # TODO(brettw) should probably be "=1". 106 # TODO(brettw) should probably be "=1".
99 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ] 107 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ]
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 # This error doesn't happen every time. In VS2013, it seems if the .pch 468 # This error doesn't happen every time. In VS2013, it seems if the .pch
461 # file doesn't exist, no error will be generated (probably MS tested this 469 # file doesn't exist, no error will be generated (probably MS tested this
462 # case but forgot the other one?). To reproduce this error, do a build, 470 # case but forgot the other one?). To reproduce this error, do a build,
463 # then delete the precompile.c.obj file, then build again. 471 # then delete the precompile.c.obj file, then build again.
464 cflags_c = [ "/wd4206" ] 472 cflags_c = [ "/wd4206" ]
465 } else if (is_mac && !is_official_build && !use_goma) { 473 } else if (is_mac && !is_official_build && !use_goma) {
466 precompiled_header = "build/precompile.h" 474 precompiled_header = "build/precompile.h"
467 precompiled_source = "//build/precompile.h" 475 precompiled_source = "//build/precompile.h"
468 } 476 }
469 } 477 }
OLDNEW
« base/logging.h ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698