Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 18144012: Allow re-running of failing tests on drt-windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 1cae1d7773c8e79629eb85a3e4fb0b962accf879..991f8deaa31e7e12fbb3700b30dddfac69d147e9 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1862,11 +1862,22 @@ class ProcessQueue {
// does that for example)
// TODO(ricow/kustermann): Issue 8206
var unexpectedOutput = commandOutput.unexpectedOutput;
- if (allowRetry && testCase.usesWebDriver
- && unexpectedOutput
- && (testCase as BrowserTestCase).numRetries > 0) {
- // Selenium tests can be flaky. Try rerunning.
- commandOutput.requestRetry = true;
+ if (unexpectedOutput && allowRetry) {
+ if (testCase.usesWebDriver
+ && (testCase as BrowserTestCase).numRetries > 0) {
+ // Selenium tests can be flaky. Try rerunning.
+ commandOutput.requestRetry = true;
+ }
+ // FIXME(kustermann): Remove this condition once we figured out why
+ // content_shell is sometimes not able to fetch resources from the
+ // HttpServer.
+ var configuration = testCase.configuration;
+ if (configuration['runtime'] == 'drt' &&
+ configuration['system'] == 'windows' &&
+ (testCase as BrowserTestCase).numRetries > 0) {
+ assert(TestUtils.isBrowserRuntime(configuration['runtime']));
+ commandOutput.requestRetry = true;
+ }
}
}
if (commandOutput.requestRetry) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698