build/android/buildbot/bb_device_status_check.py - Issue 181433020: GetAttachedDevices() should not include bad devices listed in .bad_devices file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 181433020: GetAttachedDevices() should not include bad devices listed in .bad_devices file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add ResetBadDevices and ExtendBadDevices to android_commands.py. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_status_check.py

diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py

index 7b656013f2870d605288d00e10074a2c50b7687e..f0579624a89ede372d94e8607f1b02dfe68f9446 100755

--- a/build/android/buildbot/bb_device_status_check.py

+++ b/build/android/buildbot/bb_device_status_check.py

@@ -293,6 +293,9 @@ def main():

if args:

parser.error('Unknown options %s' % args)

+ # Remove the last builds "bad devices" before checking device statuses.

+ android_commands.ResetBadDevices()

if options.restart_usb:

expected_devices = GetLastDevices(os.path.abspath(options.out_dir))

devices = android_commands.GetAttachedDevices()

« no previous file with comments | « no previous file | build/android/pylib/android_commands.py » ('j') | no next file with comments »