src/objects.cc - Issue 181433016: Fix bogus assertion in SetFastDoubleElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 181433016: Fix bogus assertion in SetFastDoubleElements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index d2ad0b7f5e866db7b3abc6b6e7b8d601db2989cd..9478549cde74dfe585b0ed349d214f9d24f45527 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -12465,7 +12465,8 @@ Handle<Object> JSObject::SetFastDoubleElement(

// Otherwise default to slow case.

ASSERT(object->HasFastDoubleElements());

ASSERT(object->map()->has_fast_double_elements());

- ASSERT(object->elements()->IsFixedDoubleArray());

+ ASSERT(object->elements()->IsFixedDoubleArray() ||

+ object->elements()->length() == 0);

NormalizeElements(object);

ASSERT(object->HasDictionaryElements());

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-347530.js » ('j') | no next file with comments »