Issue 181433009: try to deprecate fFlagsMask from SkLayerDrawLooper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181433009: try to deprecate fFlagsMask from SkLayerDrawLooper (Closed)

Created:
6 years, 10 months ago by reed1

Modified:
6 years, 9 months ago

Reviewers:
bungeman-skia, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

try to deprecate fFlagsMask from SkLayerDrawLooper We think we want to move around how flags/fields like linearText and strikeThru are specified. SkPaint has helpers for nearly all of these, but LayerInfo in the draw looper just exposes the raw bitfield. On survey of chrome/android, it appears that no one uses those, so it may be safe to just remove the feature entirely from the looper. R=bungeman@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=13607

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
M	bench/BlurRoundRectBench.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	bench/RectoriBench.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/blurroundrect.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/drawlooper.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	gm/megalooper.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	include/effects/SkLayerDrawLooper.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/effects/SkLayerDrawLooper.cpp	View		6 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/181433009/diff/1/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://codereview.chromium.org/181433009/diff/1/include/effects/SkLayerDrawLooper.h#newcode54 include/effects/SkLayerDrawLooper.h:54: * fFlagsMask selects which flags in the layer's ...

6 years, 10 months ago (2014-02-26 22:23:36 UTC) #2

reed1

6 years, 9 months ago (2014-02-27 14:27:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13607 (presubmit successful).

Expand Messages | Collapse Messages