DevTools: Replace Apple styled spinner icon with Chromium one.

DevTools: Replace Apple styled spinner icon with Chromium one.

Drive-by: replace animated PNG files with a CSS animation.

R=yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167914

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168008

[alph, 2014-02-26 12:34:58]

ptal

[yurys, 2014-02-26 12:43:10]

lgtm

https://codereview.chromium.org/181433002/diff/1/Source/devtools/front_end/in...
File Source/devtools/front_end/inspectorCommon.css (right):

https://codereview.chromium.org/181433002/diff/1/Source/devtools/front_end/in...
Source/devtools/front_end/inspectorCommon.css:35: *, *::before, *::after {
Can we do this in a separate change to make sure we don't break current styles?

[alph, 2014-02-26 12:48:20]

https://codereview.chromium.org/181433002/diff/1/Source/devtools/front_end/in...
File Source/devtools/front_end/inspectorCommon.css (right):

https://codereview.chromium.org/181433002/diff/1/Source/devtools/front_end/in...
Source/devtools/front_end/inspectorCommon.css:35: *, *::before, *::after {
On 2014/02/26 12:43:10, yurys wrote:
> Can we do this in a separate change to make sure we don't break current
styles?

Done.

[alph, 2014-02-26 15:28:40]

Committed patchset #2 manually as r167914 (presubmit successful).

[Peter Kasting, 2014-02-27 00:09:22]

On 2014/02/26 15:28:40, alph wrote:
> Committed patchset #2 manually as r167914 (presubmit successful).

I'm wondering if this could have caused timeouts on the debug bots on
inspector/profiler/canvas2d/canvas-replay-log-grid.html.  See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
.

While I wouldn't ordinarily expect something like this to be problematic, no
other changes in range look related at all, and this one is at least a DevTools
change.  Perhaps something about the CSS animation here is causing an
already-slow test, in Debug mode only, to become dramatically slower?

The regression range (from the Mac 10.6 dbg bot):
http://src.chromium.org/viewvc/blink?revision=167914&view=revision
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tr...

I'm going to try reverting this change and seeing if things improve.

[yurys, 2014-02-27 09:15:29]

On 2014/02/27 00:09:22, Peter Kasting wrote:
> On 2014/02/26 15:28:40, alph wrote:
> > Committed patchset #2 manually as r167914 (presubmit successful).
> 
> I'm wondering if this could have caused timeouts on the debug bots on
> inspector/profiler/canvas2d/canvas-replay-log-grid.html.  See
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
> .
> 
> While I wouldn't ordinarily expect something like this to be problematic, no
> other changes in range look related at all, and this one is at least a
DevTools
> change.  Perhaps something about the CSS animation here is causing an
> already-slow test, in Debug mode only, to become dramatically slower?
> 
> The regression range (from the Mac 10.6 dbg bot):
> http://src.chromium.org/viewvc/blink?revision=167914&view=revision
>
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tr...
> 
> I'm going to try reverting this change and seeing if things improve.

Surprisingly, but the test fixed after the revert
(http://src.chromium.org/viewvc/blink?revision=167947&view=revision)!

[alph-g, 2014-02-27 09:48:52]

Peter,

Thanks for taking care. It in fact causes an assertion failure somewhere in
the renderer. I've filed a bug crbug.com/347484
I'm going to mark the test an reland.

Cheers,
Alexei


On Thu, Feb 27, 2014 at 1:15 PM, <yurys@chromium.org> wrote:

> On 2014/02/27 00:09:22, Peter Kasting wrote:
>
>> On 2014/02/26 15:28:40, alph wrote:
>> > Committed patchset #2 manually as r167914 (presubmit successful).
>>
>
>  I'm wondering if this could have caused timeouts on the debug bots on
>> inspector/profiler/canvas2d/canvas-replay-log-grid.html.  See
>>
>
> http://test-results.appspot.com/dashboards/flakiness_
> dashboard.html#group=%2540ToT%2520Blink&tests=inspector%
> 252Fprofiler%252Fcanvas2d%252Fcanvas-replay-log-grid.
> html&showExpectations=true
>
>  .
>>
>
>  While I wouldn't ordinarily expect something like this to be problematic,
>> no
>> other changes in range look related at all, and this one is at least a
>>
> DevTools
>
>> change.  Perhaps something about the CSS animation here is causing an
>> already-slow test, in Debug mode only, to become dramatically slower?
>>
>
>  The regression range (from the Mac 10.6 dbg bot):
>> http://src.chromium.org/viewvc/blink?revision=167914&view=revision
>>
>
> http://build.chromium.org/f/chromium/perf/dashboard/ui/
> changelog.html?url=/trunk/src&range=253469:253474&mode=html
>
>  I'm going to try reverting this change and seeing if things improve.
>>
>
> Surprisingly, but the test fixed after the revert
> (http://src.chromium.org/viewvc/blink?revision=167947&view=revision)!
>
> https://codereview.chromium.org/181433002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[alph, 2014-02-27 10:29:32]

Committed patchset #2 manually as r168008 (presubmit successful).