Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1814323002: Mixed up vertical and horizontal :( (Closed)

Created:
4 years, 9 months ago by cbiesinger
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mixed up vertical and horizontal :( Small typo in the original change, https://codereview.chromium.org/1811753003/ BUG=594465, 593593, 590683, 593624, 593593 R=leviw@chromium.org,mstensho@opera.com Committed: https://crrev.com/d0298a936fceca5e36521aa892edf932b0728bff Cr-Commit-Position: refs/heads/master@{#382309}

Patch Set 1 #

Patch Set 2 : testexpectations/slowtests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
cbiesinger
4 years, 9 months ago (2016-03-18 21:09:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814323002/1
4 years, 9 months ago (2016-03-18 21:09:58 UTC) #4
leviw_travelin_and_unemployed
lgtm
4 years, 9 months ago (2016-03-18 21:11:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814323002/1
4 years, 9 months ago (2016-03-18 21:11:51 UTC) #8
mstensho (USE GERRIT)
lgtm
4 years, 9 months ago (2016-03-18 21:11:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/198955)
4 years, 9 months ago (2016-03-19 00:49:24 UTC) #11
cbiesinger
On 2016/03/19 00:49:24, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-21 15:01:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814323002/20001
4 years, 9 months ago (2016-03-21 15:06:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 17:02:50 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:05:20 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d0298a936fceca5e36521aa892edf932b0728bff
Cr-Commit-Position: refs/heads/master@{#382309}

Powered by Google App Engine
This is Rietveld 408576698