[chromecast] Start deprecating MediaMessageLoop.

[chromecast] Start deprecating MediaMessageLoop.

Converted CastBrowserCdmFactory and CmaMessageFilterHost by
passing the media task runner in constructor.

BUG=594234
Committed: https://crrev.com/dbe438f9875501d1a4ea64a97d44adcefc438456
Cr-Commit-Position: refs/heads/master@{#382141}

[alokp, 2016-03-18 18:05:05]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2016-03-18 18:31:42]

lgtm % nits

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
File chromecast/browser/media/cast_browser_cdm_factory.h (right):

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
chromecast/browser/media/cast_browser_cdm_factory.h:15: class
SingleThreadTaskRunner;
nit, don't need to both forward-declare and include the header.

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
chromecast/browser/media/cast_browser_cdm_factory.h:26: CastBrowserCdmFactory(
nit: explicit

[alokp, 2016-03-18 18:47:35]

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
File chromecast/browser/media/cast_browser_cdm_factory.h (right):

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
chromecast/browser/media/cast_browser_cdm_factory.h:15: class
SingleThreadTaskRunner;
On 2016/03/18 18:31:42, halliwell wrote:
> nit, don't need to both forward-declare and include the header.

oops

https://codereview.chromium.org/1814263002/diff/1/chromecast/browser/media/ca...
chromecast/browser/media/cast_browser_cdm_factory.h:26: CastBrowserCdmFactory(
On 2016/03/18 18:31:42, halliwell wrote:
> nit: explicit

Done.

[alokp, 2016-03-18 18:47:49]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-18 18:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1814263002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-03-18 18:48:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814263002/40001

[commit-bot: I haz the power, 2016-03-18 19:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:05:35]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-03-18 22:20:38]

https://codereview.chromium.org/1814263002/diff/60001/chromecast/browser/medi...
File chromecast/browser/media/cma_message_filter_host.cc (right):

https://codereview.chromium.org/1814263002/diff/60001/chromecast/browser/medi...
chromecast/browser/media/cma_message_filter_host.cc:44: class
MediaPipelineCmaMap {
Luke: I had to redo this file. Could you PTAL again. Sorry for the trouble.

I had initially moved these standalone functions into CmaMessageFilterHost to
check that these functions are indeed being called on cma thread without relying
on the global MediaMessageLoop::GetTaskRunner(). But I ran into a weak_ptr deref
issue because CmaMessageFilterHost::weak_this_ was being used to post tasks on
both UI and CMA thread.

So instead of using two weak ptr factories, I decided to convert the map into a
proper class where I can use ThreadChecker.

[halliwell, 2016-03-18 22:27:14]

On 2016/03/18 22:20:38, alokp wrote:
>
https://codereview.chromium.org/1814263002/diff/60001/chromecast/browser/medi...
> File chromecast/browser/media/cma_message_filter_host.cc (right):
> 
>
https://codereview.chromium.org/1814263002/diff/60001/chromecast/browser/medi...
> chromecast/browser/media/cma_message_filter_host.cc:44: class
> MediaPipelineCmaMap {
> Luke: I had to redo this file. Could you PTAL again. Sorry for the trouble.
> 
> I had initially moved these standalone functions into CmaMessageFilterHost to
> check that these functions are indeed being called on cma thread without
relying
> on the global MediaMessageLoop::GetTaskRunner(). But I ran into a weak_ptr
deref
> issue because CmaMessageFilterHost::weak_this_ was being used to post tasks on
> both UI and CMA thread.
> 
> So instead of using two weak ptr factories, I decided to convert the map into
a
> proper class where I can use ThreadChecker.

lgtm

[alokp, 2016-03-18 22:29:00]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-03-18 22:29:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814263002/60001

[commit-bot: I haz the power, 2016-03-19 00:33:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-19 00:35:00]

Description was changed from

==========
[chromecast] Start deprecating MediaMessageLoop.

Converted CastBrowserCdmFactory and CmaMessageFilterHost by
passing the media task runner in constructor.

BUG=594234
==========

to

==========
[chromecast] Start deprecating MediaMessageLoop.

Converted CastBrowserCdmFactory and CmaMessageFilterHost by
passing the media task runner in constructor.

BUG=594234

Committed: https://crrev.com/dbe438f9875501d1a4ea64a97d44adcefc438456
Cr-Commit-Position: refs/heads/master@{#382141}
==========

[commit-bot: I haz the power, 2016-03-19 00:35:01]

Patchset 4 (id:??) landed as
https://crrev.com/dbe438f9875501d1a4ea64a97d44adcefc438456
Cr-Commit-Position: refs/heads/master@{#382141}