Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1814243002: Add Thread TaskKind (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
turnidge, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M runtime/vm/compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/gc_marker.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/gc_sweeper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.h View 4 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 3 6 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Cutch
4 years, 9 months ago (2016-03-18 17:18:50 UTC) #3
turnidge
lgtm
4 years, 9 months ago (2016-03-18 18:13:38 UTC) #5
siva
lgtm https://codereview.chromium.org/1814243002/diff/20001/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1814243002/diff/20001/runtime/vm/thread.cc#newcode270 runtime/vm/thread.cc:270: thread->task_kind_ = kind; ASSERT(kind != kMutatorTask);
4 years, 9 months ago (2016-03-18 22:48:41 UTC) #6
Cutch
https://codereview.chromium.org/1814243002/diff/20001/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1814243002/diff/20001/runtime/vm/thread.cc#newcode270 runtime/vm/thread.cc:270: thread->task_kind_ = kind; On 2016/03/18 22:48:41, siva wrote: > ...
4 years, 9 months ago (2016-03-21 16:35:04 UTC) #7
Cutch
4 years, 9 months ago (2016-03-21 16:41:54 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
41d9f2d10777e5f6417ca03da97f93dbc7fdc38f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698