Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1814233005: Make a few more const tables smaller. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make a few more const tables smaller. Remove some tables from .h file (risk of duplication). R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4161c5ca6c5438476bf07b6dacfafb61ea611cc5

Patch Set 1 #

Patch Set 2 : Huffman tables too big. #

Patch Set 3 : rebase #

Patch Set 4 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -376 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfdoc/doc_vt.cpp View 2 chunks +102 lines, -120 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 1 2 12 chunks +46 lines, -69 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_HuffmanTable_Standard.h View 1 1 chunk +62 lines, -82 lines 0 comments Download
A + core/fxcodec/jbig2/JBig2_HuffmanTable_Standard.cpp View 1 2 3 5 chunks +32 lines, -13 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_SddProc.cpp View 1 4 chunks +20 lines, -38 lines 0 comments Download
M core/include/fxcrt/fx_arb.h View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M pdfium.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 2 chunks +12 lines, -13 lines 0 comments Download
M xfa/fgas/crt/fgas_codepage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_fontutils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fgas/layout/fgas_linebreak.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_unicode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderFormatInformation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp View 2 chunks +14 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Oliver, for review.
4 years, 9 months ago (2016-03-21 18:54:40 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-21 19:21:02 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-21 19:27:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
4161c5ca6c5438476bf07b6dacfafb61ea611cc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698