Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1814233004: Map typed data class back to the original names, we need to do this as we do not have type objects … (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Map typed data class back to the original names, we need to do this as we do not have type objects set up for these. The cost of adding type objects in each of these dart classes would be more expensive than the simple switch statement here. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/c110b6f3551740887e3bf9d50f909076acf5ae4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M runtime/vm/object.cc View 2 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 9 months ago (2016-03-18 21:43:40 UTC) #2
regis
LGTM
4 years, 9 months ago (2016-03-18 21:46:24 UTC) #3
siva
4 years, 9 months ago (2016-03-18 22:03:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c110b6f3551740887e3bf9d50f909076acf5ae4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698