mojo/shell/public/cpp/lib/shell_client.cc - Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/public/cpp/lib/shell_client.cc

Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/shell/public/cpp/lib/application_runner.cc ('K') | « mojo/shell/public/cpp/lib/application_runner.cc ('k') | mojo/shell/public/cpp/lib/shell_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/shell/public/cpp/lib/shell_client.cc

diff --git a/mojo/shell/public/cpp/lib/shell_client.cc b/mojo/shell/public/cpp/lib/shell_client.cc

index c41999bfe6d6906eb42532de9bd10c9aacb16c1c..3ca8cd7b319f18898ba6d122b91c4d087fa05ad2 100644

--- a/mojo/shell/public/cpp/lib/shell_client.cc

+++ b/mojo/shell/public/cpp/lib/shell_client.cc

@@ -17,6 +17,6 @@ bool ShellClient::AcceptConnection(Connection* connection) {

return false;

}

-void ShellClient::ShellConnectionLost() {}

+bool ShellClient::ShellConnectionLost() { return true; }

} // namespace mojo