mash/example/window_type_launcher/window_type_launcher.cc - Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/example/window_type_launcher/window_type_launcher.cc

Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mash/example/window_type_launcher/window_type_launcher.h ('k') | mash/quick_launch/quick_launch_application.h » ('j') | mojo/shell/public/cpp/lib/application_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/example/window_type_launcher/window_type_launcher.cc

diff --git a/mash/example/window_type_launcher/window_type_launcher.cc b/mash/example/window_type_launcher/window_type_launcher.cc

index 1d56a8728b0435d9eff7d1fa6938d8653c4427c1..8221bd2795cda5299860aed16eab647d6e12f17d 100644

--- a/mash/example/window_type_launcher/window_type_launcher.cc

+++ b/mash/example/window_type_launcher/window_type_launcher.cc

@@ -384,6 +384,7 @@ void WindowTypeLauncher::Initialize(mojo::Connector* connector,

widget->Show();

}

-void WindowTypeLauncher::ShellConnectionLost() {

+bool WindowTypeLauncher::ShellConnectionLost() {

base::MessageLoop::current()->QuitWhenIdle();

+ return false;

}